Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove alpha option, or repurpose it as a "strength" on #saturate pattern #2430

Open
2 tasks done
OneLiteFeather opened this issue Sep 22, 2023 · 4 comments
Open
2 tasks done
Labels
Enhancement New feature or request

Comments

@OneLiteFeather
Copy link
Member

OneLiteFeather commented Sep 22, 2023

Server Implementation

Paper

Server Version

1.20.1

Describe the bug

Due to a player request, @TheMeinerLP and I investigated how #saturate works and found out that the alpha (which is the tranparency) always has to be 255 in order to work.

To Reproduce

  1. Do //re #saturate[0][255][0][1] and set the 1 to a number that is not 255 and below
  2. See after a minute that it won't work

Expected behaviour

It should work and the transparency should be applied -> glass might be set then or something more transparent

Screenshots / Videos

No response

Error log (if applicable)

None

Fawe Debugpaste

https://athion.net/ISPaster/paste/view/4a7ba67d0e8347b9ae6d553dd08ff988

Fawe Version

Is not important here, see info below (we had several tests running at this version and latest 2.7.2)

Checklist

Anything else?

This issue is since 2021 in the code at this place:
https://pastebin.com/HK9giLqt

@OneLiteFeather OneLiteFeather added the Requires Testing This is a new issue which needs to be approved before labeled with "bug" label Sep 22, 2023
@TheMeinerLP
Copy link
Member

Would be nice also to expose some API functions from TextureUtil as API for everyone

@dordsor21
Copy link
Member

Currently TextureUtil requires an exact alpha-level match to allow for a block to be selected

@OneLiteFeather
Copy link
Member Author

How to make this better for the user that only has a parameter to put in and might not know which exact alpha values they have to put in? Should we add good examples in documentation or some fixed value options in tabcompletion at the alpha value?

@dordsor21
Copy link
Member

I would say just remove the alpha option, or repurpose it as a "strength". I.e. 255 is mixing 100% of either colour, whereas alpha=0 would effectively be not mixing the "new" colour at all

@OneLiteFeather OneLiteFeather added the Enhancement New feature or request label Oct 17, 2023
@OneLiteFeather OneLiteFeather changed the title Fix how transparency (alpha) works in #saturate Remove alpha option, or repurpose it as a "strength" on #saturate pattern Oct 17, 2023
@OneLiteFeather OneLiteFeather removed the Requires Testing This is a new issue which needs to be approved before labeled with "bug" label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants