Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make schematic command messages configurable #2556

Open
2 tasks done
RedstoneFuture opened this issue Jan 29, 2024 · 0 comments
Open
2 tasks done

Make schematic command messages configurable #2556

RedstoneFuture opened this issue Jan 29, 2024 · 0 comments
Labels
Approved Added if an issue has been approved by a maintainer Enhancement New feature or request Good first issue Simple issue which would be a good first PR for newbies interested in contributing to the project Low Priority

Comments

@RedstoneFuture
Copy link
Member

Server Implementation

Paper

Server Version

1.19.4

Describe the bug

The message fawe.worldedit.schematic.schematic.saved from strings.json is not used. The first message cannot be set.

grafik


We have 5 x TODOS in this class about message transfer.

/worldedit-core/src/main/java/com/sk89q/worldedit/command/SchematicCommands.java#L927-L929

                    TextComponent filesizeNotif = TextComponent.of( //TODO - to be moved into captions/translatablecomponents
                            SCHEMATIC_NAME + " size: " + String.format("%.1f", filesizeKb) + "kb", TextColor.GRAY);
                    actor.print(filesizeNotif);

To Reproduce

  1. //copy
  2. //schem save

Expected behaviour

Messages like the configuration.

Screenshots / Videos

No response

Error log (if applicable)

No response

Fawe Debugpaste

Fawe Version

FAWE, build 639

Checklist

Anything else?

No response

@RedstoneFuture RedstoneFuture added Requires Testing This is a new issue which needs to be approved before labeled with "bug" Bug Something isn't working Approved Added if an issue has been approved by a maintainer Low Priority and removed Requires Testing This is a new issue which needs to be approved before labeled with "bug" labels Jan 29, 2024
@OneLiteFeather OneLiteFeather added Enhancement New feature or request and removed Bug Something isn't working labels Feb 4, 2024
@NotMyFault NotMyFault added the Good first issue Simple issue which would be a good first PR for newbies interested in contributing to the project label Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Added if an issue has been approved by a maintainer Enhancement New feature or request Good first issue Simple issue which would be a good first PR for newbies interested in contributing to the project Low Priority
Projects
None yet
Development

No branches or pull requests

3 participants