Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instantiation of convex polyhedral region seems to not work sometimes #2805

Open
2 tasks done
cheeezburga opened this issue Jun 28, 2024 · 4 comments
Open
2 tasks done
Labels
Awaiting Response Waiting on the creator for delivering the information requested Requires Testing This is a new issue which needs to be approved before labeled with "bug"

Comments

@cheeezburga
Copy link

Server Implementation

Paper

Server Version

1.20.5/6

Describe the bug

I'm not sure what's causing said bug, but as stated in the title, sometimes when instantiating a convex polyhedral region, and then using said region in an EditSession or something (I used EditSession#setBlocks), the blocks aren't properly modified. This is because the region, while it has all its vertices, doesnt have all the blocks that it should have - see this (me discussing the issue on Discord) for more info.

To Reproduce

  1. Try to instantiate 2 convex polyhedral regions back to back.

Expected behaviour

It should populate the region with all the blocks, instead of just the vertices.

Screenshots / Videos

image

I know this doesn't show much, nor is it easy to see really, but this is the same screenshot I put in the Discord when discussing it. Check the link above that goes to the Discord for more context here.

Error log (if applicable)

No response

Fawe Debugpaste

https://athion.net/ISPaster/paste/view/58227cfeef4043b6a7d26f1dd759d9b2

Fawe Version

FastAsyncWorldEdit version 2.10.1-SNAPSHOT-778;c77d341

Checklist

Anything else?

No response

@cheeezburga cheeezburga added the Requires Testing This is a new issue which needs to be approved before labeled with "bug" label Jun 28, 2024
@dordsor21
Copy link
Member

Try on the latest version, There have been some changes related to region block setting

@dordsor21 dordsor21 added the Awaiting Response Waiting on the creator for delivering the information requested label Jun 29, 2024
@cheeezburga
Copy link
Author

Seems to still be an issue with the latest snapshot

@dordsor21
Copy link
Member

dordsor21 commented Jun 29, 2024

Is it definitely with exactly the same order of setting the points, etc. (between WE and FAWE)? There are no differences in the region classes

@cheeezburga
Copy link
Author

cheeezburga commented Jun 29, 2024

I'm using a different set of points with each test that I do, but yeah the region still (seemingly at random) sometimes doesn't initialize properly. Like when I set the blocks of said created region, sometimes it fills them all properly, and other times it fills only the vertices, and other times it fills (again seemingly) random blocks. I haven't been able to recreate this on WE but I'll give it another go later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Response Waiting on the creator for delivering the information requested Requires Testing This is a new issue which needs to be approved before labeled with "bug"
Projects
None yet
Development

No branches or pull requests

2 participants