Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remainingVectors handling in v2 #29

Open
laktech opened this issue Mar 8, 2020 · 0 comments
Open

remainingVectors handling in v2 #29

laktech opened this issue Mar 8, 2020 · 0 comments
Labels

Comments

@laktech
Copy link
Collaborator

laktech commented Mar 8, 2020

This ticket is for us to re-think how remainingVectors are being handled. Currently, we create an array containaing segments following the core segment. This array is searched each time a request is made to fetch a field from a segment.

We should explore using the LazySegmentFactory and a mechanism to efficiently fetch vectors for a particular SegmentType. For example, using an EnumMap to store processed vectors.

The life-cycle of a segment would be as follows. All possible segments are added to a remainaingVectors like data-structure, most likely an ArrayList of size three. When a request is made to fetch a field from a segment, the remainingVectors are scanned to locate the segment. As segment types are identified, they should be moved to the EnumMap for efficient subsequent lookups.

@laktech laktech added the v2 label Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant