Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Downloaded file name from direct link #64

Open
Itz-fork opened this issue Jun 11, 2024 · 0 comments
Open

[BUG] Downloaded file name from direct link #64

Itz-fork opened this issue Jun 11, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@Itz-fork
Copy link
Owner

Describe the bug
ddl cannot download file with it's original name, instead bot uses os.path.basename function and pass url to it to get the file name. Since not all direct links have file name at the end of the url, sometimes it downloads the file with some gibberish name like: "download.aspx?file=1344566666....

Expected behavior
Download the file from direct link with original file name.

Server details

  • OS: any
  • Python version: 3.10+
@Itz-fork Itz-fork added the bug Something isn't working label Jun 11, 2024
Itz-fork added a commit that referenced this issue Jun 15, 2024
@Itz-fork
Possible fix for #64 (#65)
33b9189 
improvements on file name finder on lib/ddl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Itz-fork