Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some changes that need to be pushed to main Spack #1140

Open
6 of 7 tasks
AlexanderRichert-NOAA opened this issue Jun 12, 2024 · 10 comments
Open
6 of 7 tasks

Some changes that need to be pushed to main Spack #1140

AlexanderRichert-NOAA opened this issue Jun 12, 2024 · 10 comments
Assignees
Labels
INFRA JEDI Infrastructure

Comments

@AlexanderRichert-NOAA
Copy link
Collaborator

AlexanderRichert-NOAA commented Jun 12, 2024

@mathomp4
Copy link
Collaborator

I will work on mepo. We have an RC in PyPi now (https://pypi.org/project/mepo/), so the package was easy to make. I'll work on our side to see if we are ready to move on with a release.

(We have to be a bit more cautious internally as the mepo state file is moving from pickle to json, so existing clones throw some warnings. We want to let users know.)

@climbfuji
Copy link
Collaborator

I will work on mepo. We have an RC in PyPi now (https://pypi.org/project/mepo/), so the package was easy to make. I'll work on our side to see if we are ready to move on with a release.

(We have to be a bit more cautious internally as the mepo state file is moving from pickle to json, so existing clones throw some warnings. We want to let users know.)

Thanks very much @mathomp4! Yes, I remembered our previous conversation and that's why assigned this to you rather than me pushing what is in our branch.

@mathomp4
Copy link
Collaborator

mathomp4 commented Jun 25, 2024

@climbfuji Well, first we see if spack mainline likes it:

spack/spack#44879

if so, I can work to get it into JSCDA spack.

ETA: Or if they take too long, I'll do the same here tomorrow or something. :)

@climbfuji
Copy link
Collaborator

Both of my packages are merged into spack develop. Both of them received updates=improvements as part of the process, which will come back to spack-stack-dev with the next merge from spack develop. I updated the list above.

@mathomp4
Copy link
Collaborator

mathomp4 commented Jul 2, 2024

Well, something weird is happening with spack mainline and mepo, so let me try and bring it in here.

ETA: Okay JCSDA/spack#447 has the updates from my two spack mainline PRs for mepo. Just in case.

@mathomp4
Copy link
Collaborator

mathomp4 commented Jul 3, 2024

Well, spack/spack#44879 is now in mainline spack so... 🤷🏼

The changes will get in some way :)

@climbfuji climbfuji mentioned this issue Jul 4, 2024
5 tasks
@AlexanderRichert-NOAA
Copy link
Collaborator Author

@srherbener can you take a look at the openmpi recipe and push changes to main spack?

@srherbener srherbener added the INFRA JEDI Infrastructure label Sep 13, 2024
@srherbener
Copy link
Collaborator

My apologies for the slow response. I've been buried with getting spack-stack-1.8.0 to build on Mac Sonoma. I'm planning on getting to the openmpi recipe next week.

@climbfuji
Copy link
Collaborator

The openblas update was merged upstream. Last one on the list is openmpi (two-level namespace)

@srherbener
Copy link
Collaborator

Sorry about the delay in getting to this.

I initially tried to cherry-pick the openmpi, macos, two-level-namespace updates but there is enough divergence since the last time we sync'd with the authoritative spack repo that the cherry picked commits are pulling in a bunch of other changes not related to the macos openmpi update. So I have created a PR by manually adding in the code in the openmpi package.py script to introduce the two_level_namespace variant: spack/spack#47202

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INFRA JEDI Infrastructure
Projects
None yet
Development

No branches or pull requests

4 participants