Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags to accordius under new REST API #8

Open
JD-P opened this issue Oct 1, 2018 · 2 comments
Open

Add tags to accordius under new REST API #8

JD-P opened this issue Oct 1, 2018 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@JD-P
Copy link
Owner

JD-P commented Oct 1, 2018

Accordius should be able to serve the client tags using the Django Rest Framework as we begin migrating away from GraphQL.

The tags implementation based on the model in lw2/models.py should conform to these specs:

Note:
This is all in addition to the basic features of any sane tagging system; Pinboard or lobste.rs is a decent starting point.
Note 2: These desiderata are not necessarily all compatible; some may be contradictory.

  • Tags may be harvested from the content itself, via special markup, or via an out-of-band input method
  • Tags should be stored as metadata, separately from the content
  • Any chunk of content should be taggable (post; comment; media asset)
  • Optionally (to the server operator), users should be able to suggest tags
  • User-suggested / crowdsourced tags should be stored separately from author-applied tags
    Whether crowdsourced and author-applied tags are displayed separately should be up to the operator of the { server | forum }
  • Optionally (to the server operator), a set of pre-supplied suggested tags should exist
    Whether users are limited to the set of pre-supplied tags should be up to the operator of the { server | forum }
  • Tag names should be case-insensitive but case-preserving

(Source)

@JD-P JD-P added enhancement New feature or request help wanted Extra attention is needed labels Oct 1, 2018
@JD-P JD-P closed this as completed Oct 2, 2018
@JD-P JD-P reopened this Oct 2, 2018
@JD-P
Copy link
Owner Author

JD-P commented Oct 2, 2018

Progress: REST framework has been added and there is now a /tags/ endpoint, however certain things still don't work, including:

  • No separate model for default/'official' tags
  • No separate model for suggesting tags
  • No options for how tags are 'displayed' server side
  • Tag names are case preserving but are not searched case insensitive yet

@JD-P
Copy link
Owner Author

JD-P commented Feb 20, 2019

Tags are now shipped in the WL 2.0 interface, but there's no search and the test suite doesn't cover all the cases I'd like yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant