Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GenScaler changes broke TH{a/c}ScalerEvtHandler #124

Open
sawjlab opened this issue Feb 2, 2017 · 1 comment
Open

GenScaler changes broke TH{a/c}ScalerEvtHandler #124

sawjlab opened this issue Feb 2, 2017 · 1 comment

Comments

@sawjlab
Copy link
Member

sawjlab commented Feb 2, 2017

In commit e86eb98 I removed IsSLot from the Decode method in GenScaler.C. IsSlot is called instead in the LoadBank methods. This breaks THaScalerEvtHandler and THcScalerEvtHandler. IsSlot needs to be either put back in the Decode method, or the ScalerEvtHandler classes need to modified to make IsSlot calls to find the scaler headers. I prefer the latter.

I plan to modify the ScalerEvtHandler classes to walk through the bank structure and only examine data in UI4 banks.

@sawjlab
Copy link
Member Author

sawjlab commented Sep 15, 2017

I rewrote THcScalerEvtHandler a while ago to walk through the bank structure and only examine data in UI4 banks. THaScalerEvtHandler may remain broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant