Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the number of flake8 errors/warnings #290

Open
hey-thanks opened this issue Jul 16, 2022 · 2 comments
Open

Reduce the number of flake8 errors/warnings #290

hey-thanks opened this issue Jul 16, 2022 · 2 comments

Comments

@hey-thanks
Copy link
Contributor

Running flake8 currently causes 200+ errors/warnings to be produced, mostly to do with whitespace and line length. If such an improvement is welcome, I'd be more than happy to submit a PR that improves this situation.

@JessicaTegner
Copy link
Owner

this is welcome.
I've been meaning to add black and flake8 as precommit hooks, for the longest time.

Something like this describes

and of course add it to the ci pipeline

@TheQuinbox
Copy link

I'd also recommend adding Isort, to sort your imports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants