Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix install for node > 9.3.0 #18

Open
JamesLefrere opened this issue Mar 5, 2018 · 1 comment
Open

Fix install for node > 9.3.0 #18

JamesLefrere opened this issue Mar 5, 2018 · 1 comment
Labels
bug Something isn't working

Comments

@JamesLefrere
Copy link
Contributor

There are errors coming from pty.js when installing on newer versions of node.

We can either find out what we're missing and make changes, or take a look at the various packages which might be outdated/no longer maintained. pty.js isn't maintained (we could use node-pty, which is), and term.jshas also been outdated in favour ofxterm.js`.
@JamesLefrere JamesLefrere added the bug Something isn't working label Mar 5, 2018
@JamesLefrere JamesLefrere mentioned this issue Mar 5, 2018
Merged
@frods
Copy link

frods commented Jun 27, 2018

Has this been deployed? I am not able to install with node 10.5.0 it doesn't seem to be respecting the .nvmrc file.

@frods frods mentioned this issue Jul 8, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@frods @JamesLefrere