GPU Documention Broken

[zjwegert]

Hi, the GPU example for a general square system appears to be broken.

using CUDA, Krylov
using CUDA.CUSPARSE, SparseArrays

# LU ≈ A for CuSparseMatrixCSC matrices
P = ilu02(A_gpu, 'O')

# Solve Py = x
function ldiv!(y, P, x)
  copyto!(y, x)                        
  sv2!('N', 'L', 'N', 1.0, P, y, 'O')     # <---- 3rd entry (`N`) not recognized 
  sv2!('N', 'U', 'U', 1.0, P, y, 'O')    # <---- 3rd entry (`U`) not recognized 
  return y
end

# Operator that model P⁻¹
y = similar(b_gpu); n = length(b_gpu); T = eltype(b_gpu)
opM = LinearOperator(T, n, n, false, false, x -> ldiv!(y, P, x))

# Solve an unsymmetric system with an incomplete LU preconditioner on GPU
(x, stats) = bicgstab(A_gpu, b_gpu, M=opM)

The arrowed lines appear to be the issue. Is this equivalent to sv2!('N', 'L', 1.0, P, y, 'O') and sv2!('N', 'U', 1.0, P, y, 'O') respectively?

[amontoison]

It seems that the problem comes from CUDA.jl.
I don't understand why we have the old behavior of the sv2! function with the last release 2.4.0.
The 3rd entry U (or N) means that the triangular has a unit diagonal (or not).
With the old syntax, you need to use the keyword argument unit_diag = true or unit_diag = false.

@Omega-xyZac can you the test the code in the commit 87c21a9 ?
I updated the documentation recently (#247).

[zjwegert]

Replied on haampie/IncompleteLU.jl#18.

[amontoison]

With the last releases of CUDA.jl, the code in the documentation is working fine.