Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] "Snap Tap"/"Rappy Snappy" for Lemokey L3 and other Keychron keyboards #287

Open
2 of 4 tasks
Mraziiiik opened this issue Jul 23, 2024 · 8 comments
Open
2 of 4 tasks
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Mraziiiik
Copy link

Mraziiiik commented Jul 23, 2024

Feature Request Type

  • Core functionality
  • Add-on hardware support (eg. audio, RGB, OLED screen, etc.)
  • Alteration (enhancement/optimization) of existing feature(s)
  • New behavior

Description

"Snap Tap" is a functionality designed to enhance the gaming experience by improving directional key input handling. Here is a detailed explanation of how it works and its benefits:

With a standard gaming keyboard, when two opposing directional keys are pressed simultaneously (e.g., 'W' and 'S' or 'A' and 'D'), the character stops moving because no movement is registered. The character remains stationary until one of the keys is released.

Snap Tap Mode:

When "Snap Tap" mode is enabled, in any instance where two opposing directional keys are detected, the last input is registered as the priority. This means the character will change directions instantly without having to release the previous key, allowing for seamless and responsive movement. Super useful for strafing.

Given the QMK firmware's flexibility and the customization options this feature could be integrated as an additional mode within the firmware.

Here i found two github projects: first implements the mode very simply where once you hold "A" and press "D", the "A" is unpressed. This however doesnt allow the player to hold "A" and spam "D" for super quick strafing because the A gets unpressed. qmk#24000

This allows the hold "A", spam "D" https://github.com/Xelus22/qmk_firmware/tree/key_interrupt_recover_playground

@Mraziiiik Mraziiiik added enhancement New feature or request help wanted Extra attention is needed labels Jul 23, 2024
@revunix
Copy link

revunix commented Jul 23, 2024

Would love it if it got the Q1 HE.

@adophoxia
Copy link

Hi, I was just wondering if you would be able to give some tips how to get this functionality? I was trying to implement it on my Keychron V1, but I couldn't get it working.

This is already being discussed over in the QMK server on Discord. Suggest you go there to ask for help since that PR is related.

@Psebcool
Copy link

Razer and Wooting just added this on all of theirs existing keyboards.

Nice feature !

@PeterMortensen
Copy link

PeterMortensen commented Jul 25, 2024

Related: [Core] Feature: Add key cancellation. qmk#24000 (2024-06-26)

@Geczy
Copy link

Geczy commented Sep 23, 2024

QMK server said they won't be working on this, the admin over there changed his mind, and refuses to merge the PR or give it anymore attention. He locks any threads related to snap tap. That being said, can we get it working on this repo?

@adophoxia
Copy link

adophoxia commented Sep 23, 2024

QMK server said they won't be working on this, the admin over there changed his mind, and refuses to merge the PR or give it anymore attention.

The PR and the issue were locked because

  1. People kept using them as troubleshooting threads when it deviated from their original purpose
  2. The messages given in [RFC] Key cancellation -- Snap Tap / SOCD / Rappy Snappy et.al. qmk/qmk_firmware#24216 were in no way related to what the RFC was asking for, aka, no one was basically answering what questions the initial post was asking for.
  3. This project is based off of volunteer work, meaning that the PR will be looked at when the team has time to do so.

He locks any threads related to snap tap.

Unless the "threads" being referred to is this one here, qmk#24204, this is because qmk#24000 was already present, making that Issue redundant, hence this one and only Issue being locked in the first place

@Geczy
Copy link

Geczy commented Sep 23, 2024

I believe locking the discussion just because a few recent responses were off-topic wasn't the right decision. It felt like an overreaction by the admin. Regarding qmk#24216

@ZhunCn
Copy link

ZhunCn commented Nov 8, 2024

SOCD has been added to the keychron hall effect keyboards, found here: 1a1cb9b

Wonder how difficult it is to port it to the other keyboards, as the current implementation uses the "HE mode" tab in Keychron Launcher to configure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

8 participants
@Geczy @PeterMortensen @revunix @ZhunCn @Psebcool @Mraziiiik @adophoxia and others