Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should reference Xposed API instead of including compiled classes #9

Open
lrq3000 opened this issue May 14, 2016 · 0 comments
Open

Comments

@lrq3000
Copy link
Contributor

lrq3000 commented May 14, 2016

I received this from rovo89

Dear developer(s),

I noticed that your module "Gyroscope Noise Filter" (net.kajos.gyronoisefilter) doesn't use the Xposed API correctly. The APK for version 1.6 includes the compiled classes of the Xposed API instead of just referencing them. This can cause various strange issues and won't work at all on KitKat and below.

Please check out http://api.xposed.info/using.html for instructions on using the API correctly. It should be very simple to correct your build settings and upload a fixed version, no matter whether you're using Android Studio or Eclipse. Please let me know if you have run into any issues with this switch, ideally by creating an issue on GitHub: https://github.com/rovo89/XposedBridge/issues

Since Xposed v84, users of your module should see a warning in the Xposed log. I plan to turn this into an error in one of the next versions, preventing such modules from being loaded. Therefore, I ask that you address this as soon as possible. If you don't want to maintain your module anymore, consider looking for a new maintainer, or in the worst case hiding your module from the repository.

Thanks,
rovo89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant