Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include WBbt & FBbt anatomy ontologies #64

Open
kevinschaper opened this issue Sep 15, 2022 · 7 comments
Open

Include WBbt & FBbt anatomy ontologies #64

kevinschaper opened this issue Sep 15, 2022 · 7 comments

Comments

@kevinschaper
Copy link
Collaborator

This will help to connect 400k & 100k gene expression edges respectively into MonarchKG.

https://obofoundry.org/ontology/fbbt.html
https://obofoundry.org/ontology/wbbt.html

@matentzn
Copy link

@matentzn
Copy link

YOu dont see them in KG phenio?

@caufieldjh
Copy link
Contributor

caufieldjh commented Sep 16, 2022

I also don't see them among the KG-Phenio nodes - just AnnotationProperty types like OBO:fbbt#part_of and OBO:wbbt#part_of

I had the prefix wrong - the FBBT nodes are prefixed with OBO:FBbt_ and the WBBT nodes are, irritatingly, prefixed with both OBO:WBbt_ and WBbt:. Both are present in the graph.

@matentzn
Copy link

Yes it is very very important that we all use the same prefix map in monarch

@kevinschaper I would suggest you use https://github.com/linkml/prefixmaps in all Monarch related projects!

@kevinschaper
Copy link
Collaborator Author

I think @caufieldjh is saying that they're OBO:FBbt_ in the Phenio graph? The edges I'm dropping right now due to missing nodes have FBbt: and WBbt: prefixes - but I do see the OBO:FBbt_ and OBO:WBbt_ nodes! Is that something you'll fix in KG Phenio? or should I fix them in our import preprocessing of KG Phenio?

I'll keep an eye out for were we can use prefixmaps. The case we have most often is that we're ingesting files that don't have an ID prefix, or have an ID prefix that we need to change - would it work to use prefixmaps almost like an enumeration to add guard rails?

@matentzn
Copy link

In this case it's probably KG phenio that needs to adapt the prefixmap library:)

@caufieldjh
Copy link
Contributor

Yes, +1 to integrating prefixmaps here.
There should be more consistent prefix usage within phenio.owl, too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants