Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calculate 'DAG' Jaccard instead of 'tree' Jaccard #15

Open
justaddcoffee opened this issue Nov 4, 2022 · 3 comments
Open

calculate 'DAG' Jaccard instead of 'tree' Jaccard #15

justaddcoffee opened this issue Nov 4, 2022 · 3 comments

Comments

@justaddcoffee
Copy link
Contributor

Currently we are using the Jaccard similarity implementation from Ensmallen - this calculates the Jaccard similarity for two nodes considering only one root node at a time (sort of the 'tree' Jaccard).

In the file we are outputting from semsim, for any pair of nodes, we write out the maximum value observed for the 'tree' Jaccard similarities, considering each root node separately.

What we'd like instead is the Jaccard similarity considering all root nodes at the same time (the 'DAG' Jaccard)

@LucaCappelletti94 - how much effort would this be to implement?

@caufieldjh

@LucaCappelletti94
Copy link
Contributor

I would estimate, very roughly, a week.

@justaddcoffee
Copy link
Contributor Author

hey @LucaCappelletti94 - @hrshdhgd and I were talking about possibly trying to implement DAG Jaccard in Ensmallen as a way to develop some rust skills

Any interest in joining us to hack with us on this some time in the coming few weeks?

@justaddcoffee
Copy link
Contributor Author

also @caufieldjh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants