Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OS X option #1

Open
ajbeaven opened this issue Aug 20, 2017 · 3 comments
Open

Add OS X option #1

ajbeaven opened this issue Aug 20, 2017 · 3 comments

Comments

@ajbeaven
Copy link
Contributor

Would be awesome to have a OS X version of this titlebar considering many electron-react apps will be compiled for Mac as well as Windows.

@KochiyaOcean
Copy link
Owner

For macOS's menu is not on the window but on the taskbar, it seems useless to create a macOS version.
If you wants to customize titlebar on macOS platform, just use titleBarStyle: 'hidden' option of browserWindow.

@ajbeaven
Copy link
Contributor Author

ajbeaven commented Aug 20, 2017

I don't see the menu as necessarily being the main draw for using this package. For me the benefit is the consolidation of the code required to customize the titlebar. In both Windows and Mac I'm planning to use a frameless browser window and will use this package to customize the titlebar as per this SO question.

Yeah I'll probably hide the titlebar menu on Mac, but it'd be nice to be able to render the default titlebar (along with any customizations I want to have eg background color) using the same package that I achieve this with on Windows.

@gnattu
Copy link

gnattu commented Jun 13, 2018

@ajbeaven If you are still interested, a macOS version is maintained here

Current version of Electron has some limit on window control and some bugs on vibrant window appearance, so that package is not able to publish yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants