Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cancelOrderByClientOid doesn't work #17

Open
mjwvb opened this issue Aug 27, 2021 · 0 comments
Open

cancelOrderByClientOid doesn't work #17

mjwvb opened this issue Aug 27, 2021 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@mjwvb
Copy link

mjwvb commented Aug 27, 2021

I'm trying to cancel my order with the custom client order id using rest.Trade.Orders.cancelOrderByClientOid(), but it doesn't do anything.

I was looking in the code, and it seems the function arguments are incorrect:

exports.cancelOrderByClientOid = async function cancelOrderByClientOid({ symbol, tradeType } = {}) {
  return await Http().DEL(`/api/v1/order/client-order/${clientOid}`);
};

Should be something like:

exports.cancelOrderByClientOid = async function cancelOrderByClientOid(clientOid) {
  return await Http().DEL(`/api/v1/order/client-order/${clientOid}`);
};

For now I have to use the unique order id with cancelOrder() as returned by postOrder(), but it's not ideal.

@ISAAC-XXYYZZ ISAAC-XXYYZZ self-assigned this Aug 13, 2024
@ISAAC-XXYYZZ ISAAC-XXYYZZ added the bug Something isn't working label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants