IpsecEspAeadRecipe does not call super on generate_sub_configurations

[jtluka]

I noticed that when sub configurations are created for the IpsecEspAeadRecipe, the super().generate_sub_configurations() is not called and instead BaseSubConfigMixin variant is called. I think this breaks the collaborative inheritance that these mixins should implement.

This applies to IpsecEspAhCompRecipe as well.

Code reference:

lnst/lnst/Recipes/ENRT/IpsecEspAeadRecipe.py

Line 126 in 86c1ddd

for subconf in ConfMixin.generate_sub_configurations(self, config):

@olichtne, could you take a look?
@Axonis, you may check whether other sub config mixins work as expected and eventually fix this. The quick check would be if NIC interrupts are pinned to a CPU if you define the dev_intr_cpu test parameter.

[olichtne]

Looking at some logs from beaker, irq cpu pinning does happen but I do agree that the code looks weird and I'm not sure how/why it works. I'll need to take a closer look.

[olichtne]

I can confirm that this is problematic, and probably super().generate_sub_configurations should be called instead. However, at the moment the only SubconfigMixin class that implements the generate_sub_configurations method is the OffloadSubconfigMixin which is not used for the Ipsec recipes. And so this is currently not causing any issues.

Instead the various Ipsec configurations are seen as sort of sub configurations, they're implemented directly as part of the recipes.

I think that a possible improvement here would be to separate the ipsec sub configurations into some mixin class/intermediary class that could theoretically cover functionality of both the IpsecEspAhCompRecipe as well as IpsecEspAeadRecipe and somehow improve code reuse and cleanliness here... but I'm not sure.