Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package does not actually zip anything #32

Open
faern opened this issue Feb 5, 2024 · 1 comment · May be fixed by #35
Open

package does not actually zip anything #32

faern opened this issue Feb 5, 2024 · 1 comment · May be fixed by #35

Comments

@faern
Copy link

faern commented Feb 5, 2024

The documentation states that:

Then run build to build the project and package to package it into a zip file.
package.zip will be present in your project directory.

But the actual zipping was removed in 1ebf590. Now package does not seem to create package.zip any longer. I'm not sure if it was a mistake to remove it (and should be added back), or if intentional (and the documentation should be fixed)

The zip package is still installed at the beginning of the container definition. If zipping is no longer desired, it could maybe be removed?

@MGlolenstine
Copy link
Owner

You are indeed correct.
An update of README is needed.

The change was debated here and you can still zip it, if that's needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants