From fba66869f1e591a573fd42e1ca79c6d64fbb913b Mon Sep 17 00:00:00 2001 From: Alex Alabuzhev Date: Sat, 27 Jan 2024 16:47:04 +0000 Subject: [PATCH] gh-782: Stack corruption in Process list plugin --- plugins/proclist/changelog | 4 ++++ plugins/proclist/handles.cpp | 6 +++--- plugins/proclist/version.hpp | 2 +- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/plugins/proclist/changelog b/plugins/proclist/changelog index 9c862ec803..9b7eec82db 100644 --- a/plugins/proclist/changelog +++ b/plugins/proclist/changelog @@ -1,3 +1,7 @@ +drkns 2024-01-27 16:45:12+00:00 - build 210 + +1. gh-782: Stack corruption in Process list plugin. + drkns 2023-05-08 19:32:14+01:00 - build 209 1. Enable consteval in fmt. diff --git a/plugins/proclist/handles.cpp b/plugins/proclist/handles.cpp index 1eaea3e1e3..c12136bfe5 100644 --- a/plugins/proclist/handles.cpp +++ b/plugins/proclist/handles.cpp @@ -101,10 +101,10 @@ static std::wstring GetFileName(HANDLE Handle) { static DWORD WINAPI GetFileNameThread(PVOID Param) { - DWORD iob[2]; - BYTE info[256]; + IO_STATUS_BLOCK iob; + FILE_BASIC_INFO info; const auto FileBasicInformation = 4; - pNtQueryInformationFile(Param, iob, info, sizeof(info), FileBasicInformation); + pNtQueryInformationFile(Param, &iob, &info, sizeof(info), FileBasicInformation); return 0; } }; diff --git a/plugins/proclist/version.hpp b/plugins/proclist/version.hpp index cf08187330..a2874a1151 100644 --- a/plugins/proclist/version.hpp +++ b/plugins/proclist/version.hpp @@ -5,7 +5,7 @@ #include -#define PLUGIN_BUILD 209 +#define PLUGIN_BUILD 210 #define PLUGIN_DESC L"Process List for FAR Manager" #define PLUGIN_NAME L"ProcList" #define PLUGIN_FILENAME L"ProcList.dll"