Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests Failing Due to Roundoff #52

Open
hphratchian opened this issue Nov 11, 2019 · 4 comments
Open

Tests Failing Due to Roundoff #52

hphratchian opened this issue Nov 11, 2019 · 4 comments
Assignees
Labels

Comments

@hphratchian
Copy link
Contributor

A few of the test jobs are failing because of round-off errors. We need to fix this. Ideas?

@leethomo86
Copy link
Contributor

The problem is the default print shows numerical noise in some of the output. Perhaps we can add an optional format specifier to printing routines (with the current formatting as the default)?

@hphratchian
Copy link
Contributor Author

That'd be useful. Are these prints all happening with prints that eventually end in MQC_General print routines?

@leethomo86
Copy link
Contributor

I don't think so, but it should be easy enough to change. I also recall that the argument order in MQC intrinsic print is inconsistent with MQC algebra1, algebra2 and EST printing. I am not sure that was ever fixed either.

@leethomo86
Copy link
Contributor

I added a high precision keyword to some printing routines in algebra 1 as a temporary measure that should be replaced with a more consistent option across all printing routines

hphratchian added a commit that referenced this issue Jul 8, 2022
hph grabbing info from main repo
hphratchian added a commit that referenced this issue Jul 8, 2022
Merge pull request #52 from MQCPack/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants