Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Implement controls UI review feedback #198

Open
8 of 10 tasks
m-m-mic opened this issue Jul 13, 2023 · 0 comments
Open
8 of 10 tasks

[Improvement] Implement controls UI review feedback #198

m-m-mic opened this issue Jul 13, 2023 · 0 comments
Labels
UI Review Feedback

Comments

@m-m-mic
Copy link
Contributor

m-m-mic commented Jul 13, 2023 •
edited
Loading

  • All: Disabled state label text should be gray (disabled color)
  • All: Option for label to be on the left side of control is missing
  • All (clarification from design team needed): Alignment of control when label is multi line hasn't been defined
  • Radio: Disabled radio buttons are still selectable in Storybook
  • Radio (clarification from design team needed): Unclear if disabled state color of outline and background should be the same
  • Radio: Padding around radio icon missing
  • Switch: Add documentation to storybook
  • Switch: Circle of selected/enabled is too big (24px instead of 20px)
  • Switch: Circle of selected/disabled is too small
  • Switch: Margin around component is missing
@m-m-mic m-m-mic self-assigned this Jul 13, 2023
m-m-mic added a commit that referenced this issue Jul 14, 2023
@m-m-mic
Merge branch 'main' into #198-controls-improvements
a35b7bf
m-m-mic added a commit that referenced this issue Jul 21, 2023
@m-m-mic
Merge branch 'main' into #198-controls-improvements
64abbb6 
# Conflicts:
#	mwui-stencil/src/components/mw-switch/mw-switch.tsx
m-m-mic added a commit that referenced this issue Jul 24, 2023
@m-m-mic
Merge branch '#198-controls-improvements' into #199-checkbox-group
765d934
Fuasmattn added a commit that referenced this issue Jul 26, 2023
@Fuasmattn
Merge pull request #200 from MaibornWolff/#198-controls-improvements
c2b104e 
#198 controls improvements
@m-m-mic m-m-mic removed their assignment Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
UI Review Feedback
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@m-m-mic