Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[commit-name] Commit names do not satisfy requirements #13

Open
mol-audit-bot opened this issue Nov 13, 2017 · 94 comments
Open

[commit-name] Commit names do not satisfy requirements #13

mol-audit-bot opened this issue Nov 13, 2017 · 94 comments
Labels
ghlint warning

Comments

@mol-audit-bot
Copy link

Please use semantic commit names
@mol-audit-bot
Copy link
Author

Bad commit name by @streamich:
d7dac6d
chore: remove key-value prefix, rename pending -> skipped and color yellow

@mol-audit-bot
Copy link
Author

Bad commit name by @Greenkeeper[bot]:
a6ad77c
docs(readme): add Greenkeeper badge

@mol-audit-bot
Copy link
Author

Bad commit name by @Greenkeeper[bot]:
0e6dd94
chore(package): update dependencies

@mol-audit-bot
Copy link
Author

Bad commit name by @streamich:
20018d5
feat: hide long stack traces by default, add option showInternalStackTraces to enable them

@streamich
Copy link
Contributor

Would be nice to know what is wrong with those commit messages.

@epoberezkin
Copy link

@claudiorodriguez @streamich The rule commit-name implements, quite pedantically :), your guidelines as configured here: https://github.com/MailOnline/gh-lint-config/blob/master/config.yaml#L36

In this case it fails because the first line of your commit should be under 64 characters (and actually your guidelines say 50).

I am not that precious about this rule, I care much more about PRs being approved, no commits without PRs, JIRA ticket numbers used in PRs (the latter two are coming soon). So I don't mind disabling it - feel free to update that config. But then, maybe it's worth updating the guidelines as well?

Closing the issue won't help - it'll get reopened tomorrow again and will be closed when there are no new offending commits in 30 days...

@epoberezkin
Copy link

Scope is not allowed by default, I added, so it won't alert on GK commits any more...

@mol-audit-bot
Copy link
Author

Re-opened: please use semantic commit names

@mol-audit-bot mol-audit-bot reopened this Nov 24, 2017
@mol-audit-bot
Copy link
Author

Bad commit name by @streamich:
f2e5d81
docs: inline Greenkeeper badge

@mol-audit-bot
Copy link
Author

Bad commit name by @streamich:
362e81d
test: add tests for LoggerTemporal

@mol-audit-bot
Copy link
Author

Bad commit name by @streamich:
ff9d307
test: add tests for LoggerBufferable

@mol-audit-bot
Copy link
Author

Bad commit name by @streamich:
776260b
docs: add screenshots, refactor reme

@mol-audit-bot
Copy link
Author

Bad commit name by @streamich:
073924d
chore: move tests to tests folders

@mol-audit-bot
Copy link
Author

Bad commit name by @streamich:
3169db2
feat: show progress while running tests

@mol-audit-bot
Copy link
Author

Bad commit name by @claudiorodriguez:
cbf54bd
chore: fix linting

@mol-audit-bot
Copy link
Author

Bad commit name by @streamich:
6cbddcd
fix: fixtures

@mol-audit-bot
Copy link
Author

Bad commit name by @streamich:
c8d33a7
feat: improve at-path stack trace formatting

@mol-audit-bot
Copy link
Author

Bad commit name by @streamich:
d921d73
feat: display error in test suite itself

@mol-audit-bot
Copy link
Author

Bad commit name by @streamich:
3f81383
fix: recognize more generic 'Expected' headers

@mol-audit-bot
Copy link
Author

Bad commit name by @streamich:
f904515
refactor: create /format folder

@mol-audit-bot
Copy link
Author

Bad commit name by @streamich:
1511ac3
fix: dont print codeFrame if empty

@mol-audit-bot
Copy link
Author

Bad commit name by @streamich:
b44dccd
fix: dont print codeFrame if empty

@mol-audit-bot
Copy link
Author

Bad commit name by @streamich:
0994dba
feat: highlight error code in terminal

@mol-audit-bot
Copy link
Author

Bad commit name by @streamich:
a6f2ce7
test: update snapshot

@mol-audit-bot
Copy link
Author

Bad commit name by @streamich:
e3584ea
refactor: for readability

@mol-audit-bot
Copy link
Author

Bad commit name by @streamich:
6284aff
test: fix tests

@mol-audit-bot
Copy link
Author

Bad commit name by @carpasse:
955640a
style: fix linting warning

@mol-audit-bot
Copy link
Author

Bad commit name by @carpasse:
6a438e1
feat: make suite label text black

improves the readability of the tag

@mol-audit-bot
Copy link
Author

Bad commit name by @carpasse:
224247d
feat: reduce output on watch mode

@mol-audit-bot
Copy link
Author

Bad commit name by @carpasse:
0e3f213
feat: color suite label red if test fail and green

... otherwise

@mol-audit-bot
Copy link
Author

Bad commit name by @carpasse:
f36fde3
fix: remove recursive call of log

not sure how this works but it is wrong so I am removing it

@mol-audit-bot
Copy link
Author

Bad commit name by @carpasse:
d864131
feat: add test counter back

some team members liked the number so adding it back

@mol-audit-bot
Copy link
Author

Bad commit name by @carpasse:
592e310
refactor: use path to generate the suite msg

@mol-audit-bot
Copy link
Author

Bad commit name by @carpasse:
026e561
fix: fix repo name in packate.json

@mol-audit-bot
Copy link
Author

Bad commit name by @carpasse:
c5f9988
docs: add logLevel doc to README

@mol-audit-bot
Copy link
Author

Bad commit name by @carpasse:
1cb6767
chore: add logLevel to reporter conf in pck.json

@mol-audit-bot
Copy link
Author

Bad commit name by @carpasse:
e1a0ccd
feat: add empty line at the start of the report

@mol-audit-bot
Copy link
Author

Bad commit name by @carpasse:
f60cef8
feat: add a log with the suite's file path

@mol-audit-bot
Copy link
Author

Bad commit name by @carpasse:
47503c0
feat: remove test number

jest run the tests in parallel so the test number does not really bring
any execution order value and can be misleading

@mol-audit-bot
Copy link
Author

Bad commit name by @carpasse:
31f1c87
feat: add log level to reporter logs

@mol-audit-bot
Copy link
Author

Bad commit name by @carpasse:
18045ee
feat: remove hyphen suffix on skip comment

@mol-audit-bot
Copy link
Author

Bad commit name by @carpasse:
f179b4c
feat: add new line at the end of the report

@mol-audit-bot
Copy link
Author

Bad commit name by @carpasse:
11aba83
feat: simplify results output and add time entry

@mol-audit-bot
Copy link
Author

Bad commit name by @carpasse:
11339b6
feat: colour output

@mol-audit-bot
Copy link
Author

Bad commit name by @carpasse:
3122fda
feat: improve outcome and test new logic

@mol-audit-bot
Copy link
Author

Bad commit name by @carpasse:
64263ad
feat: move logic to process tests output to class

@mol-audit-bot
Copy link
Author

Bad commit name by @carpasse:
324e561
feat: remove jestResultsToTAP

@mol-audit-bot
Copy link
Author

Bad commit name by @carpasse:
e21eb9d
chore: use our own reporter to run the tests

@mol-audit-bot
Copy link
Author

Bad commit name by @carpasse:
6673d05
chore: add test run to travis build

@mol-audit-bot
Copy link
Author

Bad commit name by @carpasse:
731f598
chore: remove unneeded lint disable rules

@mol-audit-bot
Copy link
Author

Bad commit name by @carpasse:
a845a4c
test: test TapReporter

@mol-audit-bot
Copy link
Author

Bad commit name by @carpasse:
df798a0
docs: update README.md

@mol-audit-bot
Copy link
Author

Bad commit name by @carpasse:
4c82b82
feat: add TapReporter

@mol-audit-bot
Copy link
Author

Bad commit name by @carpasse:
9bf89c8
chore: add travis conf

@mol-audit-bot
Copy link
Author

Bad commit name by @carpasse:
2702a5f
chore: git add dotfiles

@mol-audit-bot
Copy link
Author

Bad commit name by @carpasse:
2c034f2
chore: add package.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ghlint warning
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@epoberezkin @streamich @mol-audit-bot