-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5.0 incompatible changes plan #435
Comments
|
Apologies for delays. Working from home with kids has been... challenging. |
I'd propose:
|
That will be an entirely different gem 😄
Now that it's simple matter of ``as: :parsed If you care about this, start by changing README to prominently explain why the new modes are recommended. In short, both of these points sound more "8.0" (and maybe never) then "5.0" to me :) |
|
#332 sounds like a good step forward
... requiring `as` also sounds good (with or without removing struct
runtime dependency)
…On Tue, Nov 3, 2020 at 9:48 AM Beni Cherniavsky-Paskin < ***@***.***> wrote:
- .rest_client is definitely going private (or away) to unblock #466
<#466>.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#435 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAACYZY35UYNXZRLEGUQSNDSOA665ANCNFSM4LFBW3GA>
.
|
stumbled into the whole url parsing mess again 😞
|
plz start a v5 branch so I can make PRs against that |
|
Paternity leave ended 👶, sleeplessness continues, I didn't make progress I hoped for :-(
|
CHANGELOG for all the new merged stuff since 4.x.
changed
under_score
algorithm make api_service method work #355document watch Document watch and upcoming changes #436
change watch exceptions behavior document that watcher stops see #273 and add each_with_retry #275 (comment)
support ruby 3.0 Ruby 3.0 Compatibility #500
drop EOL ruby versions ≤2.4
I'm thinking about making all methods not documented in README
private
?get_entities
,patch_entity
etc?These are used in the wild a bit. Should I keep them until alternative Expose {create,delete,...}_entity methods to manipulate objects of dynamic kind #332? But
.public_send("get_#{...}", ...)
while clumsy is workable,.send
and a major release is perfect time to make people aware they're using undocumented functionality..rest_client
too. UPDATE: replaced by.faraday_client
, intentionally public.I don't want these to hold up 5.0, or block people from migrating.
OTOH, private methods are still available with
.send(...)
, just people will be more aware it's unsupported.several tests disabled due to expired TLS certs test TLS certs expired #483
truffleruby failing on master with "ArgumentError: unknown keyword: status"
e.g. https://github.com/abonas/kubeclient/pull/495/checks?check_run_id=2044157037
UPDATE: now passes e.g. https://github.com/abonas/kubeclient/runs/2535621628 🤷♂️
The text was updated successfully, but these errors were encountered: