Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for client-side apply #518

Open
KaoruDev opened this issue Oct 23, 2021 · 2 comments
Open

Support for client-side apply #518

KaoruDev opened this issue Oct 23, 2021 · 2 comments

Comments

@KaoruDev
Copy link

KaoruDev commented Oct 23, 2021

Is there a reason why client-side apply is not supported? I know that server-side apply is better, but my current team uses clients like Lens to manage their workloads. Testing it locally I believe Lens uses client-side apply. Looking at the managed_fields property reveals that client-side apply changes the field manager from the original field manager.

I suppose I can just use --server-side --force-conflict for now until we migrate everything? Is that the suggested migration path? I'd be happy to add it to the README.md if it is.

Cluster version: 1.18
Client version: 1.22

@cben
Copy link
Collaborator

cben commented Oct 24, 2021

Mainly because nobody implemented the necessary logic in kubeclient :-). PRs welcome.

I don't know enough to comment on safety of mixing the two and --force-conflict...

@cben
Copy link
Collaborator

cben commented Oct 24, 2021

See #358 for previous discussion and links.

There are two parts there:

  • if you want to start from a yaml file with arbitrary resource types, kubeclient is missing the plumbing to create apporpriate Client objects.
  • the merging logic itself, given a Client object for correct API group and a desired state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants