Upgrade Faraday

[d-m-u]

From #19678, this is a list of gems that we need to deal with in order to upgrade the faraday gem:

not relevant for ManageIQ

• upgrade faraday miq_bot#522

done

• manageiq-api-client (update faraday to 1.0 manageiq-api-client#90)
• update memoist for googleauth version min for faraday update #20720
• require a minimum googleauth for faraday 1.0 manageiq-providers-google#161

done and cut:

• signet (Upgrade to Faraday 1.x googleapis/signet#159)
• prometheus-api-client (Allow faraday 1.0.0 prometheus/prometheus_api_client_ruby#16) (green'd)
• xclarity_client (Update faraday to any version before January of '14 lenovo/xclarity_client#153) (it green'd, boooya)
• prometheus-alert-buffer-client (Allow updated (>0.9.2) faraday versions openshift/prometheus-alert-buffer-client-ruby#5) (https://rubygems.org/gems/prometheus-alert-buffer-client/versions/0.3.0)
• faraday-cookie_jar (at the moment the only faraday limit is >= 0.7.4)
  (https://rubygems.org/gems/faraday-cookie_jar/versions/0.0.6)
• googleauth (Update faraday googleapis/google-auth-library-ruby#252)
• google-api-client (compatible with signet 0.13)
• ansible_tower_client (technically is good to go save tests, limits are nonexistent on faraday/faraday_middleware)
• update ms_rest_azure for new faraday version manageiq-providers-azure_stack#28
• vcr (Update faraday version in gemspec vcr/vcr#794) (we're saying it green'd cause the only one that failed did so cause of an unrelated issue)

update, March 5th:

• ms_rest_azure (https://rubygems.org/gems/ms_rest_azure)
• ms_rest yayaya
  so also done now:
• azure_mgmt_compute
• azure_mgmt_network (has ms_rest_azure dependency)
• azure_mgmt_monitor (has ms_rest_azure dependency)
• azure_mgmt_resources (has ms_rest_azure dependency)

update, March 6th:

• faraday_middleware (https://rubygems.org/gems/faraday_middleware/versions/1.0.0.rc1)

@jrafanie

[jrafanie]

For future reference, this was opened because Drew found that #19678 had many ruby 2.7 deprecation warnings for faraday. We should probably coordinate with @agrare and @kbrock as many of the dependencies of faraday are providers and we might want to do this upgrade along with rails 5.2/6.0.

[agrare]

So some of these are going to be a problem because we don't own them the provider vendors do (okay so some of them turned into most of them):

• azure_mgmt_compute
• ms_rest_azure
• google-api-client
• ms_rest
• xclarity_client
• azure_mgmt_network
• azure_mgmt_monitor
• prometheus-alert-buffer-client
• googleauth
• azure_mgmt_resources
• prometheus-api-client

We can certainly see if some of these gems have newer versions that have a newer faraday but if not we'll have to try to get a PR merged upstream for each of these

[d-m-u]

The only one I'm concerned about at this point is vcr, because of vcr/vcr#788. Since the same as with Rack, the order of middleware on a Faraday stack matters, I dunno exactly what to do about the changes to the order in 1.0.0. Their build's failing cause of this issue currently.
just kidding, LJ fixed it

[d-m-u]

So I'm pretty sure we can't do this upgrade now at all because of the vcr license change (in v5.1.0). We probably need to lock vcr to 5.0.0 and keep faraday on 0.11.0, unless someone thinks it's a good idea for us to maintain our own version of vcr. I need someone in a higher pay grade to make that kind of call, as in, possibly the person who's assigned to this issue. fine, i lied 😆

[kbrock]

I plead Switzerland. LGTM

[d-m-u]

still waiting on vcr and lenovo/xclarity_client#154

[d-m-u]

Still waiting on xclarity.

[agrare]

@d-m-u all you had to do was ask 😆 https://rubygems.org/gems/xclarity_client/versions/0.6.8

[d-m-u]

thanks @agrare

[Fryguy]

I'm marking this one done, since the bot is technically unrelated to the core code base. Great work @d-m-u !