Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundancy of filter and score functions in scoring notebook #275

Open
ibludau opened this issue Jul 15, 2021 · 1 comment
Open

Comments

@ibludau
Copy link
Contributor

ibludau commented Jul 15, 2021

Is your feature request related to a problem? Please describe.
filter_with_xx functions in the scoring notebook are redundant and should be revised.

Describe the solution you'd like
Use a single combined function for 'filter_with_xxx' and 'score_xxx'.

Describe alternatives you've considered
Call 'filter_with_xxx' within 'score_xxx'.

Additional context
The 'filter_with_xxx' functions were introduced with commit: eee2972 >> 3 Aug 2020
Here, an unused 'fdr_level' parameter was additionally added.

@jalew188
Copy link
Contributor

In fasta.py,

def get_frag_dict(parsed_pep, mass_dict):
    frag_dict = {}
    frag_masses, frag_type = get_fragmass(parsed_pep, constants.mass_dict)
    ...

the mass_dict argument is never used as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants