Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discrepancies in number of segmented nuclei in WGA segmentation method between different environments #36

Open
sophiamaedler opened this issue Jul 3, 2024 · 2 comments
Assignees

Comments

@sophiamaedler
Copy link
Collaborator

Running the same notebook on the same data results in slightly differing number of nuclei between different environments/machines.

These results should be fully reproducible. The source of the discrepancy needs to be identified.

@sophiamaedler
Copy link
Collaborator Author

sophiamaedler commented Jul 3, 2024

This issue arises from different version of scikit-image being installed.

We've observed discrepancies between 0.19.3/0.20.0/0.21.0 and 0.22.0/0.24.0.
0.22.0 has given consistent results over different environments and machines.
0.19.3 has given two different set of results.

Upgrading to 0.22.0 results in problems with installing ashlar into the same environment as with the latest release it requires < 0.20.

@sophiamaedler
Copy link
Collaborator Author

As ashlar has been implemented to also use scikit-image versions > 0.20 I think we can close this and pin scikit-image to >= 0.22.0.

Long term it would be good to set up a test for this to ensure that any future changes in scikit-image do not break our reproducibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants