Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChannelSelector num_channels parameter #82

Open
namsaraeva opened this issue Sep 18, 2024 · 2 comments
Open

ChannelSelector num_channels parameter #82

namsaraeva opened this issue Sep 18, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@namsaraeva
Copy link
Collaborator

This parameter is redundant. Should be replaced with something better or we should get rid of it

@namsaraeva namsaraeva added the enhancement New feature or request label Sep 18, 2024
@namsaraeva namsaraeva self-assigned this Sep 18, 2024
@sophiamaedler
Copy link
Collaborator

How about we get rid of it and replace it with an assertion that the selected channels are smaller than the maximum number of available channels.

Not sure how best to include it though because the transformers are defined before they are applied to the data.

@namsaraeva
Copy link
Collaborator Author

@sophiamaedler yes, i was also thinking about assertion in the method, but as you mentioned, transforms are defined before they have seen the data. maybe we should just put something in the Dataset class where transforms are applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants