Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new Function instead of eval #1855

Open
mkorpela opened this issue Mar 13, 2022 · 0 comments
Open

Use new Function instead of eval #1855

mkorpela opened this issue Mar 13, 2022 · 0 comments
Labels
enhancement New feature or request priority: high

Comments

@mkorpela
Copy link
Member

Our JS execute keywords on Node side call eval to create function objects.
We should switch this to calling const func = new Function("return "+funcString)() that is much safer and does not pollute our namespace.
Current eval method could for instance accidentally re-write our node end functions etc.

@aaltat aaltat added enhancement New feature or request priority: high labels Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority: high
Projects
None yet
Development

No branches or pull requests

2 participants