Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularization of annotation tags #299

Open
meowcat opened this issue Nov 23, 2021 · 0 comments
Open

Modularization of annotation tags #299

meowcat opened this issue Nov 23, 2021 · 0 comments

Comments

@meowcat
Copy link

meowcat commented Nov 23, 2021

Related to #298, after discussion with @tsufz:

The current RMassBank is somewhat hardcoded as to

  • what tags can be used
  • what tags come from the infolist
  • what tags come from the ini file.

We have some rather workaroundy code to add more comment fields and to add some extra tags from the ini file (but not from the infolist).

We are getting more cases where other tags are desired. For example, I just helped a user who wanted CCS and RT imported from infolist.

This could be simplified with:

  • a yaml with all allowed tags
  • the user can use any of these tags either in the ini file or in the infolist,
  • When both are present, the infolist entry overwrites the ini entry, giving a warning
  • When an infolist tag overwrites a tag that was already in the spectrum (like RT, when a user wants to add known RT post-hoc to flow injection MS2), it gives a warning

If the YAML has all tags in the correct order, it can also serve as a template to reorder the tags before writing out the file.

Not handled by this proposal:

  • more tags that might come directly from the spectra
  • ???

Comments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants