Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove alternateAnalyze.R functions? #325

Open
meowcat opened this issue Apr 26, 2023 · 1 comment
Open

Remove alternateAnalyze.R functions? #325

meowcat opened this issue Apr 26, 2023 · 1 comment

Comments

@meowcat
Copy link

meowcat commented Apr 26, 2023

Are the functions in alternateAnalyze.R in active use? Those were originally implemented by ermueller 8 years ago and small touches were done by treutler later.

L167 references an occurrenceMatrix that doesn't point to anything I know.

analyzeMsMs.formula.optimized is used by analyzeMsMs.optimized is used by newStep2WorkFlow is used in validateMassBank.R -> .unitTestRMB2. This is not called from anywhere currently, and other than that I am not aware of any use of newStep2WorkFlow. Unless there is a maintainer who takes over alternateAnalyze and figures out what occurrenceMatrix is, I would advocate to remove the functionality (despite probably being more efficient than the original implementation).

@sneumann @tsufz @schymane ?

newfragData <- fragData[-which(apply(occurrenceMatrix[,rAtoms,drop=FALSE], 1, any)),]

@tsufz tsufz added this to the Feature deprecation milestone May 23, 2023
@tsufz
Copy link
Member

tsufz commented May 23, 2023

In my patchy memory, I can remember that ermueller worked also on the unit tests. Hence, it is not surprising that the functions are used in .unitTestRMB2. I suggest to deprecate the functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants