Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow CMake to build both shared and static libraries #17

Open
brad0 opened this issue Oct 6, 2018 · 2 comments
Open

Allow CMake to build both shared and static libraries #17

brad0 opened this issue Oct 6, 2018 · 2 comments

Comments

@brad0
Copy link

brad0 commented Oct 6, 2018

The autotools infrastructure for libmatroska and libebml allowed for building both shared and static libraries.

The new CMake infrastructure appears to only be able to build shared OR static libraries depending on the setting of BUILD_SHARED_LIBS instead of enabling both.

@mbunkus
Copy link
Contributor

mbunkus commented Oct 11, 2018

I'm not going to spend any time on this as I don't know a lot about cmake. That being said, I'd highly welcome a patch that implements this functionality.

@evpobr
Copy link
Contributor

evpobr commented Feb 1, 2021

Please no. CMake approach is to make separate builds, you have problems implementing this now because it is wrong way. I did this mistake with libsndfile, no real benefits, but it was very hard to support and use. Don't try to mimic Autotools, it is different in many aspects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants