Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing night mode for rgbw #4

Open
wassfila opened this issue Dec 18, 2017 · 0 comments
Open

missing night mode for rgbw #4

wassfila opened this issue Dec 18, 2017 · 0 comments

Comments

@wassfila
Copy link

Hi,
first thanks for this module it saved me a lot of time.
I noticed the night mode you had was only for the white and the rgbw is missing its night mode.
I hesitated about pull requesting your repo but to be honest, the workaround was rather straight that I did not bother, as I passed to your controller custom command of the missing ids 0xC1,...0xCC
Have a look at a working (tested) implementation here using your module.

I based my finding on this, but I got it working before finishing reading the long thread.

Actually, the milight remote only sends the off command on the user taking the finger off the remote and not on press, that wait, it knows if it was a long or a short press, in case of a long press, setting the night mode is with sending off, wait 100 ms, then send night mode. Sending the night mode directly could work if the light was off, but would switch it off if it was on, that's why a first off command is necessary.
hope this helps, let me know if something is not clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant