Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the data parameter of encrypt_data from &str to &[u8] #4

Closed
Istvan91 opened this issue Apr 28, 2021 · 2 comments
Closed

Change the data parameter of encrypt_data from &str to &[u8] #4

Istvan91 opened this issue Apr 28, 2021 · 2 comments

Comments

@Istvan91
Copy link
Contributor

While it is recommended to use ascii as the password, this is "only" a recommendation. Furthemore encryption is not only used by the standard Attribute "User-Password", but by some Vendor Specific Attributes.

To make the encrypt utility function more versatile it would be great to change the &str parameter to &[u8] (which would be a breaking change imho).

The enforcement of ascii/non-ascii should be done at a higher application level.

@MikhailMS
Copy link
Owner

Sounds like a great thing to resolve, thank you for pointing that out (didn't know that some vendor specific attr also using encryption)

Would review it asap :)

@MikhailMS
Copy link
Owner

It is done on dev locally, so should be bundled into next release (0.4.0, since we got a breaking(in a way) change)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants