Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WASM module may crash in conjunction with joystick encoders and an "on Hold" binding #1786

Open
cbrauers opened this issue May 31, 2024 · 0 comments
Labels
bug Something isn't working in a officially released version

Comments

@cbrauers
Copy link
Contributor

Describe the bug
When HID devices (e.g. Winwing FCU) provide encoders, those are rendered as buttons. Those buttons have "on release", "on hold" and "on long release" bindings. Since those encoders do not send release events, "on hold" actions may cause unexpected behavior, including the MSFS2020 WSM binding crashing

Steps To Reproduce

  1. Connect a HID device with encoders, e.g. a WinWing FCU
  2. Assign an action to "on hold" on one of the encoders
  3. Assign the same action to another input
  4. In the sim, turn the encoder
  5. Use the other input to execute that same action

Expected behavior
It is either not possible to assign "on hold" actions to encoders, or such actions are ignored

Actual behavior
The on hold action is apparently sent and never released, causing the WASM plugin to crash if a press from another source is received

Details

  • MobiFlight Version: 10.2.2.2
  • FlightSim: MSFS 2020
  • AddOn: Any plane, peripheral that acts as HID joystick with encoders supported by MobiFlight

Additional context
Found by accident (incomplete update of older MCC file) during development of VKB plugin. Later confirmed on WinWing FCU.

@DocMoebiuz DocMoebiuz added the bug Something isn't working in a officially released version label Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in a officially released version
Projects
None yet
Development

No branches or pull requests

2 participants