Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acceptance test improvement: include the number of feeds that have unparseable rows grouped by file #1775

Open
emmambd opened this issue May 29, 2024 · 1 comment
Labels
flex Rules and rule changes related to GTFS-Flex. tests Anything related to our tests.

Comments

@emmambd
Copy link
Contributor

emmambd commented May 29, 2024

As a continuation of work done for #1698 and investigation done for #1767, we want to see in the acceptance tests which feeds have unparseable rows, grouped by file.

This would help us assess how commonly occurring the unparseable error is, and for which files it is most common. It'll also help us address any prospective issues with the new Flex changes.

@emmambd emmambd added the tests Anything related to our tests. label May 29, 2024
@emmambd emmambd added the flex Rules and rule changes related to GTFS-Flex. label May 29, 2024
@emmambd emmambd modified the milestones: Flex: modifying pre-existing rules, 6.0 Validator Release May 29, 2024
@jcpitre
Copy link
Contributor

jcpitre commented Jun 3, 2024

Tasks:

  • Determine where in the report to put this information (it might already be there)
    • Decide what language to use for flagging this in the report
  • Put it in validation report (json)
  • Add to acceptance tests: json and PR comments
    • In the PR comment: summary # of feeds with unparseable rows and files associated with it
    • In json: have a list of feed_id, unparseable_file

@emmambd emmambd removed this from the 6.0 Validator Release milestone Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flex Rules and rule changes related to GTFS-Flex. tests Anything related to our tests.
Projects
None yet
Development

No branches or pull requests

2 participants