Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify variable names #15

Open
satyaborg opened this issue Aug 18, 2020 · 4 comments
Open

Simplify variable names #15

satyaborg opened this issue Aug 18, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@satyaborg
Copy link
Member

Readability aspects

@satyaborg satyaborg added the enhancement New feature or request label Aug 18, 2020
@aryanfaghihi
Copy link

Just to add to this, equity should be changed to x or some more generic name in the Wrangling ntoebook so that later when students are trying to do the challenge they don't go through so much trouble of changing each variable.

@naveenkaushik2504
Copy link
Member

I thought of working on this issue and had a look at the notebook. In order to change the notebook in such a way that there is a minimal change for the final challenge of equity, we will have to convert all the asset related variable to generic names which are at a lot of places and I don't think is a good idea, based on a good variable naming practice.

Maybe, let the attendees work through by copy-pasting the code and making the necessary changes which may result in a little loss of time, but would help them in having a better understanding? Thoughts? @satyaborg @aryanfaghihi

@aryanfaghihi
Copy link

That is a fair point, struggling with the code is how you learn. I'm just worried that they might get frustrated in the process but given they are mostly PhD students, I'm sure they are used to pushing through challenges.

@satyaborg
Copy link
Member Author

All valid arguments. Let me take another stab at the code and see if we can't simplify things any further. It should ideally leave us with fewer variables and a much more concise naming scheme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants