Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConceptRepository getByClique #50

Open
lhannest opened this issue May 7, 2018 · 0 comments
Open

ConceptRepository getByClique #50

lhannest opened this issue May 7, 2018 · 0 comments
Assignees

Comments

@lhannest
Copy link
Member

lhannest commented May 7, 2018

The following method looks incorrect, or at least has a very confusing name:

@Query("MATCH path = (concept:Concept {clique: {clique}})-[:TYPE]->(type:ConceptType) RETURN path LIMIT 1")
public Neo4jConcept getByClique(@Param("clique") String clique);

A clique is a collection of concept ID's. So shouldn't the method instead return all the concepts that are identified by that clique rather than just the first one? It seems it should instead be:

@Query("MATCH path = (concept:Concept {clique: {clique}})-[:TYPE]->(type:ConceptType) RETURN path")
public List<Neo4jConcept> getByClique(@Param("clique") String clique);

If there is only supposed to be a single Concept for any cliqueId, then why do we have both a Concept as well as a Clique in our data model? This would be redundant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants