Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not return bool for first_authenticate #179

Open
szszszsz opened this issue Jun 6, 2020 · 0 comments
Open

Do not return bool for first_authenticate #179

szszszsz opened this issue Jun 6, 2020 · 0 comments
Milestone
v4.0

Comments

@szszszsz
Copy link
Member

szszszsz commented Jun 6, 2020 •
edited
Loading

To keep style consistent, do not return bool for first_authenticate, but instead throw exception on error.

Since this will break ABI, it should be done in the next major release.

libnitrokey/libnitrokey/NitrokeyManager.h

Line 52 in 2e38681

bool first_authenticate(const char *pin, const char *temporary_password);

@szszszsz szszszsz added this to the v4.0 milestone Jun 6, 2020
sgued pushed a commit to sgued/libnitrokey that referenced this issue Feb 14, 2022
@robin-nitrokey
Merge pull request Nitrokey#179 from Nitrokey/nk3-update-timeout
d9b2e10 
nk3: Improve error message for missing confirmation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.0
Development

No branches or pull requests
1 participant
@szszszsz