From 6101b565b1e7d44bca4234236185e90e726be434 Mon Sep 17 00:00:00 2001 From: Sarah Clark Date: Tue, 1 Oct 2024 16:32:02 -0700 Subject: [PATCH] python312Packages.langchain-chroma: fix broken tests --- .../langchain-chroma/001-async-test.patch | 13 +++++++++++++ .../python-modules/langchain-chroma/default.nix | 13 +++++++++++-- 2 files changed, 24 insertions(+), 2 deletions(-) create mode 100644 pkgs/development/python-modules/langchain-chroma/001-async-test.patch diff --git a/pkgs/development/python-modules/langchain-chroma/001-async-test.patch b/pkgs/development/python-modules/langchain-chroma/001-async-test.patch new file mode 100644 index 000000000000..178fd37199f8 --- /dev/null +++ b/pkgs/development/python-modules/langchain-chroma/001-async-test.patch @@ -0,0 +1,13 @@ +diff --git a/libs/partners/chroma/tests/integration_tests/test_vectorstores.py b/libs/partners/chroma/tests/integration_tests/test_vectorstores.py +index 382b24cb5..f99a34112 100644 +--- a/tests/integration_tests/test_vectorstores.py ++++ b/tests/integration_tests/test_vectorstores.py +@@ -36,7 +36,7 @@ def test_chroma() -> None: + + assert output == [Document(page_content="foo")] + +- ++@pytest.mark.asyncio + async def test_chroma_async() -> None: + """Test end to end construction and search.""" + texts = ["foo", "bar", "baz"] diff --git a/pkgs/development/python-modules/langchain-chroma/default.nix b/pkgs/development/python-modules/langchain-chroma/default.nix index f9a35e759c8e..817676cbb189 100644 --- a/pkgs/development/python-modules/langchain-chroma/default.nix +++ b/pkgs/development/python-modules/langchain-chroma/default.nix @@ -7,6 +7,7 @@ numpy, poetry-core, pytestCheckHook, + pytest-asyncio, }: buildPythonPackage rec { @@ -23,6 +24,8 @@ buildPythonPackage rec { sourceRoot = "${src.name}/libs/partners/chroma"; + patches = [ ./001-async-test.patch ]; + build-system = [ poetry-core ]; pythonRelaxDeps = [ "chromadb" ]; @@ -35,7 +38,10 @@ buildPythonPackage rec { pythonImportsCheck = [ "langchain_chroma" ]; - nativeCheckInputs = [ pytestCheckHook ]; + nativeCheckInputs = [ + pytest-asyncio + pytestCheckHook + ]; passthru = { inherit (langchain-core) updateScript; @@ -46,6 +52,9 @@ buildPythonPackage rec { description = "Integration package connecting Chroma and LangChain"; homepage = "https://github.com/langchain-ai/langchain/tree/master/libs/partners/chroma"; license = lib.licenses.mit; - maintainers = with lib.maintainers; [ natsukium ]; + maintainers = with lib.maintainers; [ + natsukium + sarahec + ]; }; }