-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from mkYarnPackage
to yarn{Config,Build}Hook
.
#324246
Comments
Is there a form of migration guide to use the new hooks? I am using some scripted hacks to get the upstream yarn file, which also needs to be converted to the older v1 file to be used in nixpkgs. There are some dirty hacks involved, specific to Also Is there a way to not use the newly introduced hooks? Is this even desired? Or will I have to find some way to run my specially crafted |
Thanks for willing to cooperate @gador . Indeed this can become complex... The new hooks I added indeed usually makes things a bit simpler, but in such a complex case as you describe, you will have to play with it yourself, and there is no migration guide. However, there are many migration examples in #318015 . The non-trivial update scripts were discussed a bit in #318015 . I believe that with the new hooks you should be able to reach a point where you don't vendor any file (neither |
Thanks for all your work @doronbehar ! |
I think we'll also need a yarnInstallHook: #328544 |
thank you for migrating my package, sorry I didn't help in the migration |
After #318015 will beNow that #318015 is merged, we should start deprecate the usage ofmkYarnPackage
, because it is too complex, and hard to maintain. It also requires to vendor into Nixpkgs apackage.json
file for each such package (to avoid IFD, see #296856 ).I'm opening this issue before #318015 is ready / merged to refer to this issue in a small documentation I will perform there.
The following list was generated with:
xplorer
: @dit7yakuro
: @LostAttractorzammad
: @n0emis @Radvendii @NetaliDevpowerdns-admin
: @Flakebi @zhaofenglimicropad
: @rhysmdnzauto-changelog
: @pyrox0codefresh
: @takacdiagnostic-languageserver
: @pyrox0dotenv-cli
: @pyrox0element-call
: @kilimnikget-graphql-schema
: @pyrox0gramma
: @pyrox0koodo-reader
: @TomaSajtlistmonk
: @RaitoBezariuspostlight-parser
: @viraptorspectral-language-server
: @momeemttreedome
: @tengkuizdihartypst-preview
: @berbermanvim-language-server
: @doronbeharyour_spotify
: @PatrickDaGyour_spotify
: @PatrickDaGzitadel
:devpod
: @maxbrunetyaml-language-server
:prettierd
: @NotAShelf @n3oneyreact-static
:yarn2nix
: no maintainers foundapache-airflow
: @bhipple @gbpdt @ingenieroarielbutton-card
: did not found attribute automatically, file ispkgs/servers/home-assistant/custom-lovelace-modules/button-card/default.nix
multiple-entity-row
: did not found attribute automatically, file ispkgs/servers/home-assistant/custom-lovelace-modules/multiple-entity-row/default.nix
zigbee2mqtt-networkmap
: did not found attribute automatically, file ispkgs/servers/home-assistant/custom-lovelace-modules/zigbee2mqtt-networkmap/default.nix
pomerium
: @lukegb @devusbjellyseerr
: @camillemndnmatrix-appservice-discord
: @pacienmatrix-appservice-slack
: @beardhatcode @chvpmatrix-hookshot
: @chvpmjolnir
: @jojoschgrafana-image-renderer
: @Ma27lemmy
: did not found attribute automatically, file ispkgs/servers/web-apps/lemmy/ui.nix
meshcentral
: @Ma27pgadmin
: @gadorsynapse-admin
: @mkg20001 @Ma27asar
: @xvapxnear-cli
: @Ekleogv2raya
: @LostAttractortop-level
: did not found attribute automatically, file ispkgs/top-level/all-packages.nix
The text was updated successfully, but these errors were encountered: