Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure: renpy #349505

Closed
7c6f434c opened this issue Oct 18, 2024 · 0 comments · Fixed by #349516
Closed

Build failure: renpy #349505

7c6f434c opened this issue Oct 18, 2024 · 0 comments · Fixed by #349516

Comments

@7c6f434c
Copy link
Member

Steps To Reproduce

Steps to reproduce the behavior:

  1. build renpy

Build log

The issue:

ffmedia.c: In function ‘decode_audio’:
ffmedia.c:693:30: error: ‘AVFrame’ has no member named ‘channel_layout’; did you mean ‘ch_layout’?
693 |             converted_frame->channel_layout = AV_CH_LAYOUT_STEREO;
    |                              ^~~~~~~~~~~~~~
    |                              ch_layout

Additional context

#337855

(renpy.override { ffmpeg = ffmpeg_6; })
``` builds fine

Latest RenPy tag in the repo is still 8.3.1 

Upstream fix https://github.com/renpy/renpy/pull/5687 merged.

> This needs to wait for us to drop Windows 7 support, which will happen in the 8.4 release cycle.

```nix
renpy.overrideAttrs (x: { patches = x.patches ++ [
  (fetchpatch {
    url="https://github.com/renpy/renpy/pull/5687.patch";
    hash="sha256-XtCH5CjF9VtkKFgs7ormBVNaOFcg9lJljdQm5oR7jKI=";
})];})
``` builds fine.

So the question is: which is better to submit as a stop-gap build fix PR until the upstream release?

### Notify maintainers

@ShadowRZ 

### Metadata

Should not be relevant---

Add a :+1: [reaction] to [issues you find important].

[reaction]: https://github.blog/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/
[issues you find important]: https://github.com/NixOS/nixpkgs/issues?q=is%3Aissue+is%3Aopen+sort%3Areactions-%2B1-desc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant