Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xwayland-satellite broken on master #352725

Open
sodiboo opened this issue Oct 31, 2024 · 2 comments
Open

Xwayland-satellite broken on master #352725

sodiboo opened this issue Oct 31, 2024 · 2 comments
Labels
0.kind: bug 0.kind: regression Something that worked before working no longer

Comments

@sodiboo
Copy link
Contributor

sodiboo commented Oct 31, 2024

Describe the bug

On latest nixpkgs master commit, xwayland-satellite is broken.

At time of writing, the latest commit to nixos-unstable is 807e915. If the steps below don't work in a few days from now, replace nixos-unstable in commands with 807e915. The latest commit to master as i'm writing is 769a6a5.

  • Working commit (current nixos-unstable): 807e915
  • Broken commit (current master): 769a6a5

Steps To Reproduce

Steps to reproduce the behavior:

  1. nix run github:nixos/nixpkgs/nixos-unstable#xwayland-satellite -- :12
  2. Observe that it says Connected to Xwayland on :12
  3. nix run github:nixos/nixpkgs/master#xwayland-satellite -- :12
  4. Observe that Xwayland never initializes

Expected behavior

Xwayland should initialize and xwayland-satellite should connect to it within less than a second of startup. (from what i can observe, usually within less than 100ms)

Screenshots

Here is some terminal output showing several xwayland-satellite packages. The first two invocations are identical, as i have the xwayland-satellite-unstable package from my niri flake installed in my system. Those packages are used here to indicate that this isn't necessarily a problem with nixpkgs' package expression, it is inherently a problem with a dependency (likely Xwayland). They're built against nixos-unstable.

image

Additional context

This doesn't seem to be caused by us. I think it needs to be fixed upstream. I'm making this issue first, though, in case it is actually nixos-specific.

Notify maintainers

@if-loop69420 @getchoo are the other maintainers of the xwayland-satellite package

Metadata

  • system: "x86_64-linux"
  • host os: Linux 6.6.54, NixOS, 24.11 (Vicuna), 24.11.20241029.807e915
  • multi-user?: yes
  • sandbox: yes
  • version: nix-env (Nix) 2.24.9
  • channels(root): "nixos"
  • channels(sodiboo): ""
  • nixpkgs: /nix/store/m68ikm8045fj7ys7qvgr608z9l70hh1k-source

Add a 👍 reaction to issues you find important.

@sodiboo sodiboo added 0.kind: bug 0.kind: regression Something that worked before working no longer labels Oct 31, 2024
@sodiboo
Copy link
Contributor Author

sodiboo commented Oct 31, 2024

The PR updating xwayland was backported to nixos-24.05, and although that branch has no xwayland-satellite to break, my niri flake has a package that works on nixos-24.05 and when i try to check if the same regression applies there, i see no issue. This suggests the issue may not be caused by an xwayland update after all, since the backported PR (#352314) does not break an xwayland-satellite built against nixos-24.05

image

@sodiboo
Copy link
Contributor Author

sodiboo commented Oct 31, 2024

I'm currently bisecting nixpkgs to find the offending commit in case it's not that PR updating xwayland (which it seems not to be, given that it doesn't break on 24.05), This is taking a while, as Hydra doesn't cache every commit to nixpkgs, and i'm currently on the third iteration of a bisect script which has taken over am hour so far and doesn't seem to be anywhere near the end. Will update once this bisect yields a result, or if i fall asleep before that point, hopefully i'll have an update in the morning if it finished by then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: bug 0.kind: regression Something that worked before working no longer
Projects
None yet
Development

No branches or pull requests

1 participant