Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement more specific exceptions, add support for most Lin/Tartar-related exceptions in VM. #15

Open
3 tasks
NotJustAnna opened this issue Nov 14, 2021 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@NotJustAnna
Copy link
Owner

NotJustAnna commented Nov 14, 2021

Currently:

  • A lot of IllegalStateExceptions/IllegalArgumentExceptions/RuntimeExceptions are used, even if discretely.
    • Look up usages of functions check, error and removeLast.
    • There's even a AssertionError used once, at the ObjectParser.
  • There are a lot of TODOs() which generate NotImplementedErrors.
  • Tartar infamously use a lot of require, IllegalStateExceptions and IllegalArgumentExceptions.
  • Most Kotlin-land Exceptions are turned to "nativeExceptions" at VM and lose most of its data.
    • Even the complete native stacktrace is usually lost.

TO-DO list:

  • Find and replace usages of IllegalStateExceptions/IllegalArgumentExceptions/RuntimeExceptions/check/error/AssertionError with better, more specific exceptions which implement LinNativeException.
    • Open issue on Tartar to do the same when possible. Done.
  • If possible, replace TODOs() with exceptions that explain that such an operation is illegal.
  • Add the complete native stacktrace to the "nativeExceptions" to help with debugging.
@NotJustAnna NotJustAnna added this to the Version 1.0 milestone Nov 14, 2021
@NotJustAnna NotJustAnna added the enhancement New feature or request label Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant