Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

general search #167

Open
shroffk opened this issue May 8, 2023 · 3 comments
Open

general search #167

shroffk opened this issue May 8, 2023 · 3 comments
Assignees

Comments

@shroffk
Copy link
Member

shroffk commented May 8, 2023

I am hoping to add a new search functionality which would support searching across all text fields simultaneously.

match=some text

Would match any any log entry where the terms "some" or "text" appear anywhere in the title or source/desc
@georgweiss what are your thoughts

Currently I do not intend to support wildcards... unless someone can make a compelling argument for it.

@tynanford

@shroffk shroffk self-assigned this May 8, 2023
@georgweiss
Copy link
Member

I can already hear my users requesting support for "some && text" as well as "some || text".

Would it be an alternative to imply match=some text -> "some || text", while match="some text" would match the exact (case insensitive) phrase? This would however not cover the case "some && text" irrespective of where in the log entry the words occur.

@tynanford
Copy link
Contributor

Sounds good to me (as a person who has only prototyped OLOG so far)

@georgweiss
Copy link
Member

Hang on... I think I need to rephrase my previous comment. I am mixing this up with desc=some,text, which is a different use case.

I think I need to think this over once more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants