Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OneDrive File Picker v8 - Missing code example and documentation for handling shared libraries #37

Open
LukaszGawlikBridge opened this issue Apr 6, 2023 · 5 comments
Labels
documentation Improvements or additions to documentation Needs: Triage 🔍

Comments

@LukaszGawlikBridge
Copy link

Describe the bug
There is missing code example and documentation for handling shared libraries. It is complex to make it work. Making javascript-basic example to work with shared libraries requires not obvious adjustments:

  1. Configuration, set sharedLibraries: true (it is obvious, it's described in documentation, it's OK)
  2. Adjusting code for getting token (auth.js->getToken) - it's not covered by documentation or any example (there is some handling in csharp-basic but at the same time pivots->sharedLibraries is not set to true).
    image

Expected behavior
There should be code example for sharedLibraries:true (the best would be some basic javascript code). It should be also covered clearly by documentation how to make shared libraries to work.

@patrick-rodgers
Copy link
Collaborator

Can you share a bit more on where you are/got stuck or what information is missing from the docs? We can't have individual samples that cover every possible scenario but do want to ensure there is enough information folks can figure out how to load the control.

@LukaszGawlikBridge
Copy link
Author

I was facing following problem when trying to make javascript-basic to work with shared libraries (configuration typesAndSources->sharedLibraries: true), when clicking on shared team there was an exception, because handling authentication for command.type = "ms-graph" was missing.

image

  • In documentation there should be list of all authentication "command.type"s which are sent by File Picker in different situations, with some short description/explanation. External developers are not aware of them.
  • There should be code example for shared libraries (configuration typesAndSources->sharedLibraries: true). The best would be example in javascript, having correct handling of authentication "command.type"s (example like below + other "command.type"s if needed - there could be some other "command.type"s which external developers are not aware of)

image

@JCrew0
Copy link
Collaborator

JCrew0 commented Jan 3, 2024

Hey @LukaszGawlikBridge, I'm going through and looking at some of the older issues. Did anyone ever address this? If not, I can triage for someone to update the docs accordingly. Thanks!

@JCrew0 JCrew0 added documentation Improvements or additions to documentation and removed status: investigate labels Jan 3, 2024
@LukaszGawlikBridge
Copy link
Author

Hello @JCrew0 , as far as I know it has not been addressed yet (I have not been informed about any changes in documentation regarding this topic).

Regards
Lukasz

@JCrew0
Copy link
Collaborator

JCrew0 commented Mar 20, 2024

@LukaszGawlikBridge, just an update: this is still in my backlog. Will hopefully get to it soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Needs: Triage 🔍
Projects
None yet
Development

No branches or pull requests

3 participants