Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Browser: Provide documentation on how to hide Version history and Compliance Details commands #67

Open
ottD opened this issue Feb 21, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation Eng Review: Logged Internally

Comments

@ottD
Copy link

ottD commented Feb 21, 2024

Issue description
The File Browser configuration schema in the documentation does not specify an option to hide the Version history and Compliance details commands. Please consider exposing how these commands can be hidden as they are enabled by default and the version history/ compliance details iframes fail to load when using the File Browser outside of SharePoint, e.g. in a Teams application:

Refused to frame 'https://mytenant.sharepoint.com/' because an ancestor
violates the following Content Security Policy directive: 
"frame-ancestors 'self' teams.microsoft.com *.teams.microsoft.com *.skype.com *.teams.microsoft.us local.teams.office.com 
*.office365.com *.powerapps.com *.yammer.com engage.cloud.microsoft *.officeapps.live.com *.office.com *.microsoft365.com
*.stream.azure-test.net *.microsoftstream.com *.dynamics.com
*.microsoft.com onedrive.live.com *.onedrive.live.com securebroker.sharepointonline.com".

To Reproduce
Use the File Browser component in a Teams application and configure it according to the documented File Browser configuration schema
Both Version history and Compliance details commands are enabled by default but unusable due to the issue described above.

Expected behavior
Document how to hide the Version history and Compliance details commands such that 3rd party applications can use the FileBrowser without these failing commands.

Screenshots

Screenshot 2024-02-21 113752

image

Details
Note, the File Browser used in the native Teams experience hides Version history and Compliance details so there must be a way to configure the File Browser accordingly. I understand that you don't want to expose all File Browser configuration options but given that these commands do not work properly there needs to be a way to hide them.

For completeness, below is the File Browser configuration that is currently used in my Teams application:

{
    "sdk": "8.0",
    "authentication": {},
    "messaging": {
        "origin": "https://localhost:53000",
        "channelId": "852adf29-a4d2-43a2-a2c3-7bf923c4465c"
    },
    "theme": "dark",
    "navigation": {
        "mode": "host"
    },
    "leftNav": {
        "enabled": false
    },
    "entry": {
        "sharePoint": {
            "byPath": {
                "web": "/sites/Dev/Testing",
                "list": "/sites/Dev/Testing/MattersTesting",
                "folder": "/sites/Dev/Testing/MattersTesting/TeamsTab/Long Folder path"
            }
        }
    },
    "breadcrumb": {
        "root": {
            "sharePoint": {
                "byPath": {
                    "folder": "/sites/Dev/Testing/MattersTesting/TeamsTab/Long Folder path"
                }
            }
        }
    },
    "commands": {
        "open": {
            "handlers": [
                {
                    "filters": [
                        "folder"
                    ],
                    "target": "host"
                }
            ]
        }
    }
}
@ottD
Copy link
Author

ottD commented Mar 19, 2024

@JCrew0 Any comment regarding additional configuration options for the FileBrowser component? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Eng Review: Logged Internally
Projects
None yet
Development

No branches or pull requests

2 participants