Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IATI] Org ID checks - when no org-id ref are found #1359

Open
stevieflow opened this issue Sep 21, 2021 · 2 comments
Open

[IATI] Org ID checks - when no org-id ref are found #1359

stevieflow opened this issue Sep 21, 2021 · 2 comments
Assignees
Labels

Comments

@stevieflow
Copy link
Member

This file is interesting:

https://iati.fcdo.gov.uk/iati_files/converted_files/bbc-world-service-oda-data.xml

Here. there's two participating-org

<participating-org ref="GB-GOV-1" role="1">
<narrative>UK - Foreign, Commonwealth and Development Office</narrative>
</participating-org>
<participating-org role="4">
<narrative>BBC World Service</narrative>
</participating-org>

The CoVE results are: https://iati.cove.opendataservices.coop/data/4257a6d8-5cb6-4578-a83f-c84d2f557818 - but it's a blank box:

IATI-CoVE (4)

I think this is because:

  • we don't highlight orgs that are the same as the reporting-org
  • we dont highlight orgs that have no @ref attribute

@kindly would that be the case?

@kindly
Copy link
Contributor

kindly commented Sep 21, 2021

Yes that is right. I spotted a sample file that did the same.

@stevieflow
Copy link
Member Author

Should / could we add some default text when there is no feedback to give?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants