Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RefResolver will be deprecated in jsonschema #112

Closed
jpmckinney opened this issue Feb 23, 2023 · 7 comments
Closed

RefResolver will be deprecated in jsonschema #112

jpmckinney opened this issue Feb 23, 2023 · 7 comments

Comments

@jpmckinney
Copy link
Contributor

jpmckinney commented Feb 23, 2023 •
edited
Loading

See python-jsonschema/jsonschema#1049

Affects CustomRefResolver.

New docs: https://python-jsonschema.readthedocs.io/en/stable/referencing/

I think this mainly requires following this example https://python-jsonschema.readthedocs.io/en/stable/referencing/#automatically-retrieving-resources-over-http

And replacing references to self.store and self.handlers per https://python-jsonschema.readthedocs.io/en/stable/referencing/#migrating-from-refresolver
@jpmckinney
Copy link
Contributor Author

jpmckinney commented Feb 23, 2023 •
edited
Loading

Hmm, not sure why jsonschema was locked in 0.26.1 #94. Log message just mentions:

we use internal tools that are not available in V4

But there is no discussion anywhere of what these "internal tools" are.

@jpmckinney
Copy link
Contributor Author

Ah, lib-cove uses the non-public module jsonschema._utils...

@jpmckinney
Copy link
Contributor Author

jsonschema v4 can be allowed via #113

@jpmckinney
Copy link
Contributor Author

Closed via #113

@jpmckinney
Copy link
Contributor Author

Oops, nevermind, would still need to update the deprecated usage.

@jpmckinney jpmckinney reopened this Mar 10, 2023
@jpmckinney
Copy link
Contributor Author

v4.18 is live now, so I'll make a PR.

@jpmckinney jpmckinney mentioned this issue Jul 7, 2023
Closed
@jpmckinney
Copy link
Contributor Author

Closed by #142 (adapts #123).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade to jsonschema 4.18.0
1 participant
@jpmckinney